eric-haibin-lin commented on a change in pull request #11591: [MXNET-331]
Single machine All Reduce Topology-aware Communication (Updated)
URL: https://github.com/apache/incubator-mxnet/pull/11591#discussion_r201217514
##########
File path: tests/python/gpu/test_kvstore_gpu.py
##########
@@ -86,34 +102,48 @@ def check_rsp_pull(kv, count, ctxs, is_same_rowid=False,
use_slice=False):
check_rsp_pull(kv, 4, [mx.gpu(i//2) for i in range(4)], use_slice=True)
check_rsp_pull(kv, 4, [mx.cpu(i) for i in range(4)], use_slice=True)
- check_rsp_push_pull('local')
- check_rsp_push_pull('device')
- check_rsp_push_pull('device', is_push_cpu=False)
+ # test fails intermittently. temporarily disabled till it gets fixed.
tracked at https://github.com/apache/incubator-mxnet/issues/9384
+ # check_rsp_push_pull('local')
Review comment:
remove unused code? You're already testing it (this was just enabled last
week)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
