roywei commented on a change in pull request #11631: Fix batchnorm problem with 
sparse matrices when fix_gamma=True
URL: https://github.com/apache/incubator-mxnet/pull/11631#discussion_r201451126
 
 

 ##########
 File path: tests/python/unittest/test_sparse_operator.py
 ##########
 @@ -2098,6 +2098,77 @@ def check_scatter_ops(name, shape, lhs_stype, 
rhs_stype, forward_mxnet_call, for
                           lambda l, r: l + r,
                           rhs_is_scalar=True, verbose=False, density=0.5)
 
+
+@with_seed()
 
 Review comment:
   It will be great to add a reference to test_batchnorm_training in 
test_operator.py, and note this is to test row_sparse fallback correctness. 
Just to avoid confusion for other developers who work on batchnorm.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to