larroy commented on a change in pull request #11636: [WIP] set MXNET_DATA_DIR 
as base for downloaded models through base.data_dir()
URL: https://github.com/apache/incubator-mxnet/pull/11636#discussion_r201517185
 
 

 ##########
 File path: python/mxnet/base.py
 ##########
 @@ -47,6 +48,32 @@
     integer_types = (int, long, np.int32, np.int64)
     py_str = lambda x: x
 
+
+def data_dir_default():
+    """
+
+    :return: default data directory depending on the platform and environment 
variables
+    """
+    system = platform.system()
+    if system == 'Windows':
+        return os.environ.get('APPDATA')
+    elif system == 'Linux' or system == 'Darwin':
+        if 'XDG_DATA_HOME'in os.environ:
 
 Review comment:
   freedesktop convention 
https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to