larroy commented on a change in pull request #11641: [WIP] make CachedOp a 
normal operator
URL: https://github.com/apache/incubator-mxnet/pull/11641#discussion_r201623330
 
 

 ##########
 File path: src/imperative/cached_op.cc
 ##########
 @@ -1047,6 +1047,105 @@ void CachedOp::Backward(
   Engine::Get()->set_bulk_size(prev_bulk_size);
 }
 
+struct CachedOpActualState {
+  std::shared_ptr<CachedOp> op;
+  OpStatePtr forward_state;
+
+  CachedOpActualState(std::shared_ptr<CachedOp> op) {
 
 Review comment:
   By reference?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to