piyushghai commented on a change in pull request #11626: [MXNET-651] MXNet Model Backwards Compatibility Checker URL: https://github.com/apache/incubator-mxnet/pull/11626#discussion_r201795191
########## File path: tests/nightly/model_backwards_compatibility_check/train_mxnet_legacy_models.sh ########## @@ -0,0 +1,57 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +#Author: Piyush Ghai + +run_models() { + echo '==========================' + echo "Running training files and preparing models" + echo '==========================' + python mnist_mlp_module_api_train.py Review comment: Also, the training script would not be a part of nightly runs. It will only be run when a new version of MXNet is released in order to refresh the trained models inventory on S3. This run can either be manual or automated by editing the train_mxnet_legacy_models.sh script. So any random dataset unavailability issues should not block the nightly inference files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
