marcoabreu commented on a change in pull request #11633: Fix dist kvstore for
trainer and flaky dist kvstore test
URL: https://github.com/apache/incubator-mxnet/pull/11633#discussion_r201801549
##########
File path: tests/nightly/dist_sync_kvstore.py
##########
@@ -388,8 +388,42 @@ def check_trainer_kv_type(stype, grad_stype,
update_on_kv):
check_trainer_kv_type('default', 'default', False)
check_trainer_kv_type('default', 'row_sparse', True)
check_trainer_kv_type('row_sparse', 'row_sparse', True)
- print('worker ' + str(my_rank) + ' passed test_gluon_trainer')
-
+ print('worker ' + str(my_rank) + ' passed test_gluon_trainer_type')
+
+def test_gluon_trainer_step():
+ def check_trainer_step():
+ ctx = mx.cpu(0)
Review comment:
is this on purpose? We run our KVstore tests on a GPU instance. if we don't
require GPU, please downgrade to using a cpu instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
