anirudh2290 commented on a change in pull request #11630: [WIP] Fix flaky test
test_deconvolution
URL: https://github.com/apache/incubator-mxnet/pull/11630#discussion_r201836613
##########
File path: tests/python/unittest/common.py
##########
@@ -94,6 +95,23 @@ def random_seed(seed=None):
random.seed(next_seed)
+def assert_raises_cudnn_disabled(assertion_error=False):
+ def test_helper(orig_test):
+ @make_decorator(orig_test)
+ def test_new(*args, **kwargs):
+ cudnn_disabled = (os.getenv('CUDNN_DISABLED') == "ON")
+ if not cudnn_disabled or mx.context.current_context().device_type
== 'cpu':
+ orig_test(*args, **kwargs)
+ else:
+ if assertion_error:
Review comment:
why disable the test when it can be avoided. If it is for visibility then we
already have an open issue. we can also call it a disabled test since it is
disabled for cudnn off.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services