KellenSunderland commented on a change in pull request #11579: Fix arm64 docker
build
URL: https://github.com/apache/incubator-mxnet/pull/11579#discussion_r202026122
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -251,11 +243,11 @@ build_android_armv7() {
report_ccache_usage
}
-build_android_arm64() {
+build_android_armv8() {
set -ex
cd /work/build
# There are other ways for CMake to cross compile android, like setting the
following variables
-# below. But right not it doesn't work as expected, we need to find what's the
best strategy to
+# below. But right not it doesn't work as expected, we need to find what's the
best strategy to
# build with CMake in Android.
# -DCMAKE_ANDROID_NDK=${CROSS_ROOT} \
Review comment:
Can we clean up these comments? They're in git history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
