juliusshufan commented on issue #10921: [MXNET-500]Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-404558871 @marcoabreu @szha @eric-haibin-lin @piiswrong @zheng-da I move the cases to tests/python/mkl from tests/python/unittests, and per the previous dicussion with Marc, I think it is better to classify these cases for mkldnn backend but not unified for GPU and CPU, the justification is, the main purpose of these cases are checking if the MKLDNN-enabled Op can cope with a sliced or reshaped Ndarray; as MKLDNN sometimes invovles the specific memory layout, and this is a speciality of MKLDNN but not CUDA/CUDNN. Though this is a backend specific feature, since python test cases are qualified to fullfil the testing purpose, I think it make sense to keep it for mkldnn backend. May I have your comments on how to move forward? Via these cases, valid issue(s) have been identified, and it is helpful to track the regression for MKLDNN integration with MXNET. Thanks. BTW: I checked the CI failure with this commit, seems they are not relevant to the cases. Thanks for all your time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
