zhreshold commented on a change in pull request #11650: remove windows note for
dataloader, fix deprecated warning in python3.7
URL: https://github.com/apache/incubator-mxnet/pull/11650#discussion_r202114323
##########
File path: tests/python/unittest/test_gluon_data.py
##########
@@ -205,24 +206,20 @@ def batchify(self, data):
nd.array(labels, dtype=labels.dtype,
ctx=context.Context('cpu_shared', 0)),
nd.array(y_lens, ctx=context.Context('cpu_shared', 0)))
-
- # This test is pointless on Windows because Windows doesn't fork
- if platform.system() != 'Windows':
- data = Dummy(True)
- loader = DataLoader(data, batch_size=40, batchify_fn=data.batchify,
num_workers=2)
- for epoch in range(1):
- for i, data in enumerate(loader):
- if i % 100 == 0:
- print(data)
- print('{}:{}'.format(epoch, i))
-
- data = Dummy(True)
- loader = DataLoader(data, batch_size=40,
batchify_fn=data.batchify_list, num_workers=2)
- for epoch in range(1):
- for i, data in enumerate(loader):
- if i % 100 == 0:
- print(data)
- print('{}:{}'.format(epoch, i))
+ # sanity tests
+ # enable test on windows
+ data = Dummy(False)
Review comment:
- I am deliberately switch one test case to fixed shape, and the rest one is
responsible for the random test.
- Will remove the unnecessary comments
BTW, my PR disappeared in CI yesterday but show up today, do you have a clue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
