marcoabreu commented on a change in pull request #11656: Fix batchnorm problem 
with sparse matrices when fix_gamma=True
URL: https://github.com/apache/incubator-mxnet/pull/11656#discussion_r202120457
 
 

 ##########
 File path: tests/python/mkl/test_mkldnn.py
 ##########
 @@ -233,7 +233,7 @@ def check_batchnorm_training(stype):
                            mx.nd.array(beta).tostype(stype)]
             mean_std = [mx.nd.array(rolling_mean).tostype(stype), 
mx.nd.array(rolling_std).tostype(stype)]
 
-            test = mx.symbol.BatchNorm(data, fix_gamma=True)
+            test = mx.symbol.BatchNorm(data, fix_gamma=False)
 
 Review comment:
   Ah I see, sorry, got a lot of PRs swirling around my head. Let me rephrase 
to ensure I got it right: This means that the test case with gamma=True is 
basically invalid until that issue has been resolved and that's why you are 
changing it, correct?
   If yes, we're good to go. Sorry for the caused inconvenience.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to