haojin2 commented on a change in pull request #11664: Fall back when sparse
arrays are passed to MKLDNN-enabled operators
URL: https://github.com/apache/incubator-mxnet/pull/11664#discussion_r202168071
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -240,5 +240,135 @@ def check_batchnorm_training(stype):
for stype in stypes:
check_batchnorm_training(stype)
+@with_seed()
Review comment:
As we discussed earlier, we should still have such test in place for testing
the fallback logic with USE_MKLDNN=1. Depends on the logic in InferStorage, we
may need an extra test in test_sparse_operator/test_operator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
