marcoabreu commented on a change in pull request #11664: Fall back when sparse
arrays are passed to MKLDNN-enabled operators
URL: https://github.com/apache/incubator-mxnet/pull/11664#discussion_r202208647
##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -240,5 +240,135 @@ def check_batchnorm_training(stype):
for stype in stypes:
check_batchnorm_training(stype)
+@with_seed()
Review comment:
Right, but these tests can then be placed in the regular operator tests. The
fallback will be implicitly tested. I don't see any mkldnn specific code that
would justify it from not being run with MXNet or cuda as backend.
I had the same discussion in another PR from shufan (on mobile ATM). Would
you mind joining in over there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
