zhreshold commented on a change in pull request #11676: MXNet ONNX export - Dot op support URL: https://github.com/apache/incubator-mxnet/pull/11676#discussion_r202767556
########## File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py ########## @@ -435,6 +435,72 @@ def convert_pad(node, **kwargs): return [node] +def create_helper_trans_node(op_name, input_node, node_name): + """create extra transpose node for dot operator""" + helper, _, _ = import_onnx_modules() + + node_name = op_name + "_" + node_name + trans_node = helper.make_node( + 'Transpose', + inputs=[input_node], + outputs=[op_name+"_a"], Review comment: why still have hardcoded "_a"? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services