szha commented on a change in pull request #11566: [MXNET-626] Add while_loop
URL: https://github.com/apache/incubator-mxnet/pull/11566#discussion_r203209315
##########
File path: benchmark/python/control_flow/foreach_rnn.py
##########
@@ -157,16 +157,22 @@ def benchmark_rnn(cell, rnn_data, states):
ndim = 512
seq_len = 100
batch_sizes = [1, 32]
- cells = [gluon.rnn.GRUCell(ndim, prefix='rnn_'),
+ cells = [gluon.rnn.RNNCell(ndim, prefix='rnn_'),
+ gluon.rnn.GRUCell(ndim, prefix='rnn_'),
gluon.rnn.LSTMCell(ndim, prefix='rnn_')]
ctxs = [mx.cpu(0), mx.gpu(0)]
for cell in cells:
for ctx in ctxs:
for batch_size in batch_sizes:
if len(get_gpus()) == 0 and ctx == mx.gpu(0):
continue
-
- if isinstance(cell, gluon.rnn.GRUCell):
+ if isinstance(cell, gluon.rnn.RNNCell):
Review comment:
nit: there's quite a bit of repetition in the below code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
