eric-haibin-lin commented on a change in pull request #11643: Added the diag()
operator
URL: https://github.com/apache/incubator-mxnet/pull/11643#discussion_r203489537
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -1302,6 +1302,14 @@ def flip(self, *args, **kwargs):
"""
return op.flip(self, *args, **kwargs)
+ def diag(self, k=0, **kwargs):
Review comment:
Please also update
https://github.com/apache/incubator-mxnet/blob/master/docs/api/python/ndarray/ndarray.md
and symbol/symbol.md (probably add it to the section of array creation
routines like
https://docs.scipy.org/doc/numpy/reference/routines.array-creation.html)
@reminisce maybe we should also mention adding documentation in the operator
tutorial ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
