haojin2 commented on a change in pull request #11825: Fix non-determinism of
dot(csr.T, dns) = dns with tests
URL: https://github.com/apache/incubator-mxnet/pull/11825#discussion_r203890320
##########
File path: src/operator/tensor/dot-inl.cuh
##########
@@ -35,6 +35,13 @@
namespace mxnet {
namespace op {
+// Returns integer log2(a) rounded up
+inline int log2i(size_t a) {
Review comment:
IMO a generic utility should be a templated one to support all data types
instead of something like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
