OneRaynyDay commented on a change in pull request #11833: [MXNET-688] Fix
quantization divide by zero errors
URL: https://github.com/apache/incubator-mxnet/pull/11833#discussion_r203913461
##########
File path: python/mxnet/contrib/quantization.py
##########
@@ -274,22 +279,21 @@ def _get_optimal_threshold(arr, num_bins=8001,
num_quantized_bins=255):
max_val = np.max(arr)
th = max(abs(min_val), abs(max_val))
- hist, hist_edeges = np.histogram(arr, bins=num_bins, range=(-th, th))
+ hist, hist_edges = np.histogram(arr, bins=num_bins, range=(-th, th))
Review comment:
`edges` is mispelled as `edeges` throughout the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
