eric-haibin-lin commented on a change in pull request #11825: Fix
non-determinism of dot(csr.T, dns) = dns with tests
URL: https://github.com/apache/incubator-mxnet/pull/11825#discussion_r203939868
##########
File path: src/operator/tensor/dot-inl.cuh
##########
@@ -35,6 +35,13 @@
namespace mxnet {
namespace op {
+// Returns integer log2(a) rounded up
+inline int log2i(size_t a) {
Review comment:
Taking log2 integer does sound like a common utility. We always need to
calculate this before calling `SortByKey `. Can we have `log2i(size_t)` and
`log2i(unsigned int)` in `common/utils.h` and replace other occurrences?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
