mkolod commented on a change in pull request #11325: [MXNET-703] TensorRT 
runtime integration
URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r205228198
 
 

 ##########
 File path: include/mxnet/executor.h
 ##########
 @@ -152,14 +152,14 @@ class Executor {
   static Executor* SimpleBind(nnvm::Symbol symbol,
 
 Review comment:
   @piiswrong The method that requires mutability is 
`GraphExecutor::ReinitGraph`, which can be found 
[here](https://github.com/mkolod/incubator-mxnet/blob/tensorrt_integration/src/executor/graph_executor.cc#L978:L1078).
 This doesn't pose any breaking changes to the existing code base, as long as 
the C API is used to handle frontend bindings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to