haojin2 opened a new pull request #11888: Re-enabling test_operator/test_operator_gpu.test_dot URL: https://github.com/apache/incubator-mxnet/pull/11888 ## Description ## Getting rid of the fixed seed for test_operator/test_operator_gpu.test_dot as the flakiness cannot be reproduced. ## Checklist ## ### Essentials ### - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [x] Get rid of the fixed seed for test_operator/test_operator_gpu.test_dot ## Comments ## Can pass more than 10000 times on both CPU & GPU: ``` MXNET_TEST_COUNT=10000 nosetests -s --verbose tests/python/unittest/test_operator.py:test_dot /home/ubuntu/anaconda3/lib/python3.6/site-packages/urllib3/contrib/pyopenssl.py:46: DeprecationWarning: OpenSSL.rand is deprecated - you should use os.urandom instead import OpenSSL.SSL /home/ubuntu/anaconda3/lib/python3.6/site-packages/nose/util.py:453: DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec() inspect.getargspec(func) [INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=194063305 to reproduce. test_operator.test_dot ... ok ---------------------------------------------------------------------- Ran 1 test in 9446.096s OK ``` ``` MXNET_TEST_COUNT=10000 nosetests -s --verbose tests/python/gpu/test_operator_gpu.py:test_dot /home/ubuntu/anaconda3/lib/python3.6/site-packages/urllib3/contrib/pyopenssl.py:46: DeprecationWarning: OpenSSL.rand is deprecated - you should use os.urandom instead import OpenSSL.SSL /home/ubuntu/anaconda3/lib/python3.6/site-packages/nose/util.py:453: DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec() inspect.getargspec(func) [INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=2632151 to reproduce. test_operator_gpu.test_dot ... ok ---------------------------------------------------------------------- Ran 1 test in 36.951s OK ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
