eric-haibin-lin commented on a change in pull request #11325: [MXNET-703]
TensorRT runtime integration
URL: https://github.com/apache/incubator-mxnet/pull/11325#discussion_r205311142
##########
File path: src/executor/graph_executor.cc
##########
@@ -1018,20 +1155,37 @@ void GraphExecutor::Init(nnvm::Symbol symbol,
g.GetAttr<StorageTypeVector>("storage_type"));
}
+ if (dmlc::GetEnv("MXNET_USE_TENSORRT", false)) {
Review comment:
Just to clarify I didn't mean to make it static, but rather to cache the
value in the Executor constructor. The `bool log_verbose_ ` variable is a
member variable only to that executor, so you can set env var at runtime to get
different executor if you call simple_bind twice on the same symbol with and
without TRT. That being that, it's a minor improvement suggestion since it's
not being repeatedly looked up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
