rahul003 opened a new pull request #11910: Improving documentation and error 
messages for Async distributed training with Gluon
URL: https://github.com/apache/incubator-mxnet/pull/11910
 
 
   ## Description ##
   When using asynchronous mode of distributed training, updater has to be 
provided to the server. Since Symbolic mode of training always does updates on 
server, it generally has no issue. But Gluon provides the flexibility to 
determine whether to update weights on server or worker using 
`update_on_kvstore`. Also the default value for this is false, i.e. to perform 
weight updates on worker. This results in crash when using async mode with 
Gluon as this person realized 
https://github.com/apache/incubator-mxnet/issues/11855. We need to prevent 
users from running into this.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] add error message if user sets the variable to false explicitly
   - [x] document the behavior of kvstore
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to