rahul003 commented on a change in pull request #11910: Improving documentation
and error messages for Async distributed training with Gluon
URL: https://github.com/apache/incubator-mxnet/pull/11910#discussion_r205921780
##########
File path: python/mxnet/gluon/trainer.py
##########
@@ -187,6 +187,11 @@ def _init_kvstore(self):
arg_arrays = {param.name: param.data(self._contexts[0]) for param
in self._params}
kvstore, update_on_kvstore = _create_kvstore(config['kvstore'],
len(self._contexts),
arg_arrays)
+ if kvstore and 'async' in kvstore.type and
config['update_on_kvstore'] is not None\
Review comment:
If the user does not set that variable explicitly (default way), then I set
it to the right value. If the user explicitly sets it to false, then raised the
error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
