haojin2 commented on a change in pull request #11482: make gluon rnn layers
hybrid blocks
URL: https://github.com/apache/incubator-mxnet/pull/11482#discussion_r205957050
##########
File path: src/operator/tensor/matrix_op-inl.h
##########
@@ -182,14 +205,16 @@ inline bool ReshapeShape(const nnvm::NodeAttrs& attrs,
oshape[inf_idx] = dshape.Size() / oshape.Size();
}
} else {
- return (*out_attrs)[0].ndim();
+ if ((*out_attrs)[0].ndim()) {
+ return ReverseReshapeInferShape(&(*in_attrs)[0], oshape);
+ }
Review comment:
Should this be
```c++
if ((*out_attrs)[0].ndim()) {
return ReverseReshapeInferShape(&(*in_attrs)[0], oshape);
}
return 0;
```
instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
