benkamphaus commented on issue #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#issuecomment-408732517 It appears to be the case that the new constructor arglist for `NDArrayIter` breaks backwards compatibility, which is the cause of the current Clojure CI broken message: ```No matching ctor found for class org.apache.mxnet.io.NDArrayIter, compiling:(org/apache/clojure_mxnet/io.clj:216:4)``` The cause is straight forward -- the constructor call [here](https://github.com/lanking520/incubator-mxnet/blob/dataiter/contrib/clojure-package/src/org/apache/clojure_mxnet/io.clj#L216-L223) is no longer valid due to the change to the args required for `NDArrayIter` as [declared here](https://github.com/apache/incubator-mxnet/pull/11844/files#diff-b63b7056575260dd87ef51b1bf01fc9cR44). This constructor call on the clojure side backs `ndarray-iter`, and there are tests, specs, and examples and the changes in required args to `ndarray-iter` would need those to change as well. (i.e. this impacts the API/contract level, not just an implementation concern below those). Note that the keyword args in the Clojure API means that `ndarray-iter` could back a call to both the previous NDArrayIter constructor and the form with the new args (using additional, optional args to the same function in the Clojure API). Otherwise, I'm not sure what the expectation/desire is here without more context. I'll discuss with @gigasquid as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
