taliesinb commented on a change in pull request #11928: Generalized
reshape_like operator
URL: https://github.com/apache/incubator-mxnet/pull/11928#discussion_r206186591
##########
File path: src/operator/tensor/elemwise_unary_op.h
##########
@@ -476,6 +476,31 @@ void HardSigmoidBackward(const nnvm::NodeAttrs& attrs,
});
}
+struct ReshapeLikeParam : public dmlc::Parameter<ReshapeLikeParam> {
+ int lhs_begin, rhs_begin;
+ dmlc::optional<int> lhs_end, rhs_end;
+ DMLC_DECLARE_PARAMETER(ReshapeLikeParam) {
+ DMLC_DECLARE_FIELD(lhs_begin).set_default(0).describe(
+ "Defaults to 0. "
+ "The beginning index along which the lhs dimensions are to be "
+ "reshaped. Supports negative indices.");
+ DMLC_DECLARE_FIELD(lhs_end)
+ .set_default(dmlc::optional<int>())
+ .describe("Defaults to None. The ending index to be used, "
+ "The ending index along which the lhs dimensions are to be "
Review comment:
This describe comment seems to have a spurious sentence fragment in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
