junrushao1994 commented on issue #11942: [MXNET-749] Bug fixes in control flow operators URL: https://github.com/apache/incubator-mxnet/pull/11942#issuecomment-409127832 @zheng-da And I am not sure if my understanding is correct, but I guess another thing we should discuss is: is the `SubgraphSanityCheck` we did in [NNVM](https://github.com/dmlc/tvm/blob/142c7da392a232e5610b6d7bcfd5b40f9c4dd027/nnvm/src/core/graph.cc#L24), actually too restrictive? For example, there is a huge graph, containing two subgraphs `A` and `B`, and `A` and `B` has there own subgraphs, say `A.0` and `B.0`. Some intermediate results are shared across several subgraphs. If `CutSubgraph` fails to copy-and-split them into different subgraphs, then `SubgraphSanityCheck` will raise an error. However, in theory, `CutSubgraph` should do the copy-and-split stuff, but it is not working on my case. I suspect there is more bugs, either in control flow operators, or in subgraph cut. Could we discuss sometime?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
