jimdunn commented on issue #11808: remove mod from arity 2 version of load-checkpoint in clojure-package URL: https://github.com/apache/incubator-mxnet/pull/11808#issuecomment-409391806 @gigasquid Hey, I have a question about those tests. The arity 2 function has `load-optimizer-states` as `false`, which is the default. So I initially thought it might not pass the test because it wouldn't load the optimizer states, but apparently the optimizer state isn't actually checked since my test worked ok. So I wondered if there was a point of the `init-optimizer` bit in those tests and found that removing those lines didn't have an effect. https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/test/org/apache/clojure_mxnet/module_test.clj#L108 I saw that the scala tests for this are basically identical. I tried to run them to see if to see if they would be fine without the initOptimizer step, but I was unable to figure out the scala pacakge install and I don't have time to spend on that. In any case, I'm not sure what the best thing to do is. I can just add my test "as is" and not worry about this apparently unnecessary step, or even remove that step from the test. But if it's supposed to matter and we care about the optimizer state for these tests, then that should be fixed. The problem for me with this is that I can't see how to access the optimizer state in `mod` to make the comparison. Maybe I'm making too much of it, but I found it confusing that this `load-optimizer-states` is explicitly set in the test and neither it nor the `init-optimizer` step affect the success of the test. Am I making sense? Thoughts on this?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
