apeforest opened a new pull request #11958: Remove fixed seed in flaky test
URL: https://github.com/apache/incubator-mxnet/pull/11958
 
 
   ## Description ##
   Getting rid of the fixed seed for test_module.test_monitor as the flakiness 
cannot be reproduced.
   Issue reported: https://github.com/apache/incubator-mxnet/issues/11706
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [X] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] Get rid of the fixed seed for test_module.test_monitor
   
   ## Comments ##
   Can pass more than 10k times on CPU:
   ```
   test_module.test_monitor ... [DEBUG] 1 of 10000: Setting test np/mx/python 
random seeds, use MXNET_TEST_SEED=341502476 to reproduce.
   [DEBUG] 2 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=1911419844 to reproduce.
   [DEBUG] 3 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=2081311389 to reproduce.
   [DEBUG] 4 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=1300376807 to reproduce.
   [DEBUG] 5 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=747761998 to reproduce.
   ...
   [DEBUG] 9993 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=1960288796 to reproduce.
   [DEBUG] 9994 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=126697537 to reproduce.
   [DEBUG] 9995 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=508893563 to reproduce.
   [DEBUG] 9996 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=800422860 to reproduce.
   [DEBUG] 9997 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=1152882755 to reproduce.
   [DEBUG] 9998 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=2102456845 to reproduce.
   [DEBUG] 9999 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=343132162 to reproduce.
   [DEBUG] 10000 of 10000: Setting test np/mx/python random seeds, use 
MXNET_TEST_SEED=1430358686 to reproduce.
   ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 84.045s
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to