anirudh2290 commented on a change in pull request #11482: make gluon rnn layers hybrid blocks URL: https://github.com/apache/incubator-mxnet/pull/11482#discussion_r206717107
########## File path: tests/python/gpu/test_gluon_gpu.py ########## @@ -0,0 +1,203 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import print_function +import sys +import os +import time +import multiprocessing as mp +import unittest +import mxnet as mx +import numpy as np +import unittest +from nose.tools import assert_raises +from mxnet.test_utils import check_consistency, set_default_context, assert_almost_equal +from mxnet.base import MXNetError +from mxnet import autograd +from numpy.testing import assert_allclose + +curr_path = os.path.dirname(os.path.abspath(os.path.expanduser(__file__))) +sys.path.insert(0, os.path.join(curr_path, '../unittest')) +from common import setup_module, with_seed, teardown, assert_raises_cudnn_disabled +from test_gluon import * +from test_loss import * +from test_gluon_rnn import * Review comment: test_gluon_rnn has assert_raises_cudnn_disabled for `test_rnn`. test_rnn doesnt raise an error though. I think it should be removed from test_gluon_rnn.py ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
