gigasquid commented on issue #11808: remove mod from arity 2 version of load-checkpoint in clojure-package URL: https://github.com/apache/incubator-mxnet/pull/11808#issuecomment-409403262 Makes total sense. Looking at the code for this, it is not very easy to test that the optimizer states are loaded. Basically, the optimizer states are serialized to a`test-0000.states` file and then loaded into the model. It sets a private variable called `preloadOptStates` which is then used in the `init-optimizer` https://github.com/apache/incubator-mxnet/blob/master/scala-package/core/src/main/scala/org/apache/mxnet/module/Module.scala#L404 to set it. Unfortunately, I can't find a good way to verify this in the tests so I would just recommend to leave them as is unless someone else has a better idea. Thanks for digging into this and enhancing the tests to make them better 👍 .
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
