roywei opened a new pull request #11978: [MXNET-771] Fix Flaky Test test_executor.py:test_dot URL: https://github.com/apache/incubator-mxnet/pull/11978 ## Description ## Fix #11686, removed fixed seed in test_executor.py:test_dot 1. Verified this test is flaky and the values for comparison are slightly off 2. Flakiness comes from sym.dot of tow large tensor. The input tensor size was original set to be a random size in range of (1,500). Reduced 500 to 200 to make it more stable. 3. The test still fails with 1e-6 tolerance, increased it to 1e-5 (reasonable for fp32) 4. removed helper function `reldiff` (calculating relative difference) with `assert_almost_equal` in `mxnet.test_utils` which can handle corner case better (when `norm` in `reldiff` is 0) 5. removed fixed seed ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-771](https://issues.apache.org/jira/browse/MXNET-771) created (except PRs with tiny changes) - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### See description ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
