sbodenstein commented on a change in pull request #11984: WIP - Generalized
broadcast_like operator
URL: https://github.com/apache/incubator-mxnet/pull/11984#discussion_r207245550
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -137,6 +137,17 @@ struct BroadcastToParam : public
dmlc::Parameter<BroadcastToParam> {
}
};
+struct BroadcastLikeParam : public dmlc::Parameter<BroadcastLikeParam> {
+ TShape input_axes;
+ TShape other_axes;
+ DMLC_DECLARE_PARAMETER(BroadcastLikeParam) {
+ DMLC_DECLARE_FIELD(input_axes).set_default(TShape())
Review comment:
I don't like input_axes and other_axes given that the two inputs are called
`lhs` and `rhs`. I think `rhs_axes` and `lhs_axes` is much more consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
