KellenSunderland commented on a change in pull request #12000: Redesign Jenkinsfiles URL: https://github.com/apache/incubator-mxnet/pull/12000#discussion_r207957392
########## File path: ci/Jenkinsfile_utils.groovy ########## @@ -0,0 +1,152 @@ +// -*- mode: groovy -*- + +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// initialize source codes +def init_git() { + deleteDir() + retry(5) { + try { + // Make sure wait long enough for api.github.com request quota. Important: Don't increase the amount of + // retries as this will increase the amount of requests and worsen the throttling + timeout(time: 15, unit: 'MINUTES') { + checkout scm + sh 'git submodule update --init --recursive' + sh 'git clean -xdff' + } + } catch (exc) { + deleteDir() + error "Failed to fetch source codes with ${exc}" + sleep 2 + } + } +} + +def init_git_win() { + deleteDir() + retry(5) { + try { + // Make sure wait long enough for api.github.com request quota. Important: Don't increase the amount of + // retries as this will increase the amount of requests and worsen the throttling + timeout(time: 15, unit: 'MINUTES') { + checkout scm + bat 'git submodule update --init --recursive' + bat 'git clean -xdff' + } + } catch (exc) { + deleteDir() + error "Failed to fetch source codes with ${exc}" + sleep 2 + } + } +} + +// pack libraries for later use +def pack_lib(name, libs=mx_lib) { + sh """ +echo "Packing ${libs} into ${name}" +echo ${libs} | sed -e 's/,/ /g' | xargs md5sum +""" + stash includes: libs, name: name +} + +// unpack libraries saved before +def unpack_lib(name, libs=mx_lib) { + unstash name + sh """ +echo "Unpacked ${libs} from ${name}" +echo ${libs} | sed -e 's/,/ /g' | xargs md5sum +""" +} + +def publish_test_coverage() { + // Fall back to our own copy of the bash helper if it failed to download the public version + sh '(curl --retry 10 -s https://codecov.io/bash | bash -s -) || (curl --retry 10 -s https://s3-us-west-2.amazonaws.com/mxnet-ci-prod-slave-data/codecov-bash.txt | bash -s -)' +} + +def collect_test_results_unix(original_file_name, new_file_name) { + if (fileExists(original_file_name)) { + // Rename file to make it distinguishable. Unfortunately, it's not possible to get STAGE_NAME in a parallel stage + // Thus, we have to pick a name manually and rename the files so that they can be stored separately. + sh 'cp ' + original_file_name + ' ' + new_file_name + archiveArtifacts artifacts: new_file_name + } +} + +def collect_test_results_windows(original_file_name, new_file_name) { + // Rename file to make it distinguishable. Unfortunately, it's not possible to get STAGE_NAME in a parallel stage + // Thus, we have to pick a name manually and rename the files so that they can be stored separately. + if (fileExists(original_file_name)) { + bat 'xcopy ' + original_file_name + ' ' + new_file_name + '*' + archiveArtifacts artifacts: new_file_name + } +} + + +def docker_run(platform, function_name, use_nvidia, shared_mem = '500m') { + def command = "ci/build.py --docker-registry ${env.DOCKER_CACHE_REGISTRY} %USE_NVIDIA% --platform %PLATFORM% --docker-build-retries 3 --shm-size %SHARED_MEM% /work/runtime_functions.sh %FUNCTION_NAME%" + command = command.replaceAll('%USE_NVIDIA%', use_nvidia ? '--nvidiadocker' : '') + command = command.replaceAll('%PLATFORM%', platform) + command = command.replaceAll('%FUNCTION_NAME%', function_name) + command = command.replaceAll('%SHARED_MEM%', shared_mem) + + sh command +} + + + +def assign_node_labels(args) { + NODE_LINUX_CPU = args.linux_cpu + NODE_LINUX_GPU = args.linux_gpu + NODE_LINUX_GPU_P3 = args.linux_gpu_p3 + NODE_WINDOWS_CPU = args.windows_cpu + NODE_WINDOWS_GPU = args.windows_gpu +} + +// assign any caught errors here +err = null +def main_wrapper(args) { + // hander: Core logic Review comment: spelling. Plus if we're going to have two handlers I'd give them both descriptive names. i.e. failure_handler, build_handler. I'm also not sure about the name handler, since we're only handling errors in one case and not responding to explicit events. Maybe build and handle_error? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
