haojin2 commented on a change in pull request #12040: Fix flaky tests for
quantize and requantize
URL: https://github.com/apache/incubator-mxnet/pull/12040#discussion_r207967154
##########
File path: tests/python/quantization/test_quantization.py
##########
@@ -121,7 +120,7 @@ def check_requantize(shape, min_calib_range=None,
max_calib_range=None):
max_range.asscalar(),
min_calib_range=min_calib_range,
max_calib_range=max_calib_range)
- assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np)
+ assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np, atol = 1)
Review comment:
Why do we allow `atol=1`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
