sbodenstein edited a comment on issue #11984: Generalized broadcast_like 
operator
URL: https://github.com/apache/incubator-mxnet/pull/11984#issuecomment-411049304
 
 
   Ok, I think we are talking about different cases. Obviously, this PR 
shouldn't change this case: `mx.sym.broadcast_like()`. It should indeed "take 
the whole". This case is also being tested for.
   
   But the example I gave was not this, but the case where axes are specified 
with empty tuples as values: `mx.sym.broadcast_like(lhs_axes=(), rhs_axes=())`. 
I don't see any tests for this case. And the behaviour seems strange: 
`lhs_axes=(5,3)` means take two axes, `lhs_axes=(5,)` means take one axis, and 
`lhs_axes=()` means take all axes. I'm also happy if it just fails for the 
empty tuple case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to