tlby commented on a change in pull request #12038: MXNET-776 [Perl] Better
documentation/bug fixes.
URL: https://github.com/apache/incubator-mxnet/pull/12038#discussion_r208427711
##########
File path: perl-package/AI-MXNetCAPI/mxnet_typemaps.i
##########
@@ -1215,5 +1215,5 @@
%typemap(in) (void* callback_handle)
{
- $1 = (void*)$input;
+ $1 = (void*)newSVsv($input);
Review comment:
okay great. You know me, I think of how everything at the low level will
behave in a tight loop. Sounds like that's not the case here so no worries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
