marcoabreu commented on issue #11493: Fix MXPredReshape in the c_predict_api
URL: https://github.com/apache/incubator-mxnet/pull/11493#issuecomment-412233719
 
 
   The default is atol=e-20 and rtol=e-5. I don't know by how much we can 
expect a derivation here.
   
   I think the default values are reasonable. The only case when they can cause 
problems is when we are working with randomized input data. Since we got both 
cases, I'd prefer to not increase the default tolerances but instead rather 
have them increased specifically if we use random data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to