eric-haibin-lin closed pull request #12070: Fix flaky test -
test_deformable_convolution and psroipooling with_type
URL: https://github.com/apache/incubator-mxnet/pull/12070
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/python/gpu/test_operator_gpu.py
b/tests/python/gpu/test_operator_gpu.py
index 9dbf5f0825a..c0329a5853e 100644
--- a/tests/python/gpu/test_operator_gpu.py
+++ b/tests/python/gpu/test_operator_gpu.py
@@ -1470,8 +1470,12 @@ def test_psroipooling_with_type():
'psroipool_rois': 'null'},
arg_params=arg_params)
-@with_seed(1234)
+@with_seed()
def test_deformable_psroipooling_with_type():
+ tol = {np.dtype(np.float32): 1e-1,
+ np.dtype(np.float64): 1e-3,
+ np.dtype(np.float16): 1e-2}
+
arg_params = {
'deformable_psroipool_rois': np.array([[0, 10, 22, 161, 173], [0, 20,
15, 154, 160]])}
@@ -1499,13 +1503,17 @@ def test_deformable_psroipooling_with_type():
'deformable_psroipool_trans': np.float16}},
]
- check_consistency(sym, ctx_list, grad_req={'deformable_psroipool_data':
'write',
- 'deformable_psroipool_rois':
'null',
- 'deformable_psroipool_trans':
'write'}, arg_params=arg_params)
+ check_consistency(sym, ctx_list, scale=0.1, tol=tol,
+ grad_req={'deformable_psroipool_data': 'write',
+ 'deformable_psroipool_rois': 'null',
+ 'deformable_psroipool_trans': 'write'},
arg_params=arg_params)
-@with_seed(1234)
+@with_seed()
def test_deformable_convolution_with_type():
+ tol = {np.dtype(np.float32): 1e-1,
+ np.dtype(np.float64): 1e-3}
+
sym = mx.sym.contrib.DeformableConvolution(num_filter=3, kernel=(3,3),
name='deformable_conv')
# since atomicAdd does not support fp16 (which deformable conv uses in
backward), we do not test fp16 here
ctx_list = [{'ctx': mx.gpu(0),
@@ -1521,18 +1529,14 @@ def test_deformable_convolution_with_type():
# 'deformable_conv_offset': (2, 18, 8, 8),
# 'type_dict': {'deformable_conv_data': np.float16,
'deformable_conv_offset': np.float16}},
]
- # wider tolerance needed for true-fp16 NCHW test above
- tol = {np.dtype(np.float16): 0.5,
- np.dtype(np.float32): 1e-3,
- np.dtype(np.float64): 1e-5,
- np.dtype(np.uint8): 0,
- np.dtype(np.int32): 0}
- check_consistency(sym, ctx_list, tol=tol)
+
+ check_consistency(sym, ctx_list, scale=0.1, tol=tol)
# test ability to turn off training on bias
- check_consistency(sym, ctx_list, grad_req={'deformable_conv_data': 'write',
- 'deformable_conv_offset':
'write',
- 'deformable_conv_weight':
'write',
- 'deformable_conv_bias':
'null'}, tol=tol)
+ check_consistency(sym, ctx_list, scale=0.1, tol=tol,
+ grad_req={'deformable_conv_data': 'write',
+ 'deformable_conv_offset': 'write',
+ 'deformable_conv_weight': 'write',
+ 'deformable_conv_bias': 'null'})
@with_seed()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
