[GitHub] zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ test for LRN operator

[GitBox]

zheng-da commented on a change in pull request #11831: [MXNET-484] MKLDNN C++ 
test for LRN operator
URL: https://github.com/apache/incubator-mxnet/pull/11831#discussion_r209790288
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_lrn-inl.h
 ##########
 @@ -229,6 +232,7 @@ void MKLDNNLRNBackward(const OpContext &ctx, const 
LRNParam &param,
   MKLDNNStream::Get()->RegisterPrim(
         lrn_backward(pdesc_bwd, mkldnn::primitive::at(*data_mem),
         mkldnn::primitive::at(*diff_mem), *ws_mem, *diff_src_mem.second));
+  CommitOutput(in_grad, diff_src_mem);
 
 Review comment:
   good catch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services