zhreshold commented on a change in pull request #12131: [MXNET-737][WIP] Add
last batch handle for imageiter
URL: https://github.com/apache/incubator-mxnet/pull/12131#discussion_r210182860
##########
File path: python/mxnet/image/image.py
##########
@@ -1149,22 +1158,44 @@ def __init__(self, batch_size, data_shape,
label_width=1,
else:
self.auglist = aug_list
self.cur = 0
+ self._is_allowed_reading = True
+ self._cached_data = None
+ # handle the last batch
+ if self.seq and last_batch == 'discard':
+ new_seq_n = len(self.seq) - len(self.seq) % batch_size
+ self.seq = self.seq[:new_seq_n]
Review comment:
this is not correct, you now change the behavior from initial shuffle to per
epoch shuffle, so self.seq must be shuffled in reset, and the slice can not be
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
