vandanavk commented on issue #8270: 10 Undefined names in Python code
URL: 
https://github.com/apache/incubator-mxnet/issues/8270#issuecomment-413254384
 
 
   Thanks @KellenSunderland 
   
   @cclauss I don't see the errors
   ```
   ./tests/python/unittest/test_engine_import.py:33:13: F821 undefined name 
'reload'
               reload(mxnet)
               ^
   ./tests/nightly/model_backwards_compatibility_check/common.py:216:12: F821 
undefined name 'cmp'
       return cmp(normalize(version1), normalize(version2))
   ```
   I've tried flake8 and pylint, Python2 and Python3.
   
   Although I do see 
   ```
   ************* Module mxnet.ndarray
   python/mxnet/ndarray/__init__.py(34): [E0602 ] Undefined variable 'ndarray'
   ************* Module mxnet.symbol
   python/mxnet/symbol/__init__.py(31): [E0602 ] Undefined variable 'symbol'
   ```
   After these are fixed, I'll add "undefined-variable" to pylintrc in the CI 
build. This will check future commits to python/mxnet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to