cclauss commented on a change in pull request #12200: [MXNET-696] 'make pylint'
should run pylint under both Python 2 and Python 3
URL: https://github.com/apache/incubator-mxnet/pull/12200#discussion_r210496110
##########
File path: Makefile
##########
@@ -534,7 +534,10 @@ cpplint:
--exclude_path src/operator/contrib/ctc_include
pylint:
- pylint --rcfile=$(ROOTDIR)/ci/other/pylintrc
--ignore-patterns=".*\.so$$,.*\.dll$$,.*\.dylib$$" python/mxnet
tools/caffe_converter/*.py
+ python3 --version # Python 3.5.2
Review comment:
A developer on such a machine will be unable to see syntax errors that they
may be creating:
* __print "Hi"__ is valid Python 2 but is a syntax error in Python 3
* __async def func():__ is valid Python 3 but is a syntax error in Python 2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
