marcoabreu commented on a change in pull request #12200: [MXNET-696] 'make
pylint' should run pylint under both Python 2 and Python 3
URL: https://github.com/apache/incubator-mxnet/pull/12200#discussion_r210602333
##########
File path: Makefile
##########
@@ -534,7 +534,13 @@ cpplint:
--exclude_path src/operator/contrib/ctc_include
pylint:
- pylint --rcfile=$(ROOTDIR)/ci/other/pylintrc
--ignore-patterns=".*\.so$$,.*\.dll$$,.*\.dylib$$" python/mxnet
tools/caffe_converter/*.py
+ python3 -m pip install --upgrade --user pylint # v1.8.3 --> v2.1.1
Review comment:
We pin the versions on purpose and don't want them to be upgraded like that.
Otherwise, an update of pylint may result in new errors being thrown and all
pipelines are suddenly blocked.
https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/ubuntu_python2.sh
https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/ubuntu_python3.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
