aaronmarkham commented on issue #12102: site-wide social include
URL: https://github.com/apache/incubator-mxnet/pull/12102#issuecomment-413600077
 
 
   @lebeg Take a look at the [preview on your 
mobile](http://34.201.8.176/versions/social_media_update/) or just resize the 
screen to pretty small - the social links are text in that hamburger menu, but 
only for "mobile", and that view doesn't trigger until under 600px. So then 
desktop would never see them. I could just add text to the desktop nav instead 
of buttons, and the CSS complexity goes away.
   
   The current CSS and implementation of boostrap appears pretty messed up. It 
behaves inappropriately, and I found that the entanglements are huge. Various 
JS scripts are injecting or overwriting stuff after boostrap has rendered which 
could explain why bootstrap doesn't work as expected. Like there's a [footer 
bug](https://github.com/apache/incubator-mxnet/pull/11921#issuecomment-410153362)
 that me, Krishnan, or SK couldn't figure out. Maybe someone else can, but it 
seems like it is basically a start-over job with the design, or hack on what we 
have. 
   
   I can tinker with the CSS a bit more and try to get rid of that crowding you 
see - make buttons smaller increase padding and so forth, but I'm going to have 
to find a better monitor as what I have does get that high of resolution. 
   
   I like incremental improvement. If anyone else wants to take a stab at the 
same feature, that's cool. Or fix/upgrade the bootstrap implementation. That 
would be awesome. 
   
   I just think we really should improve the marketing game on the site and try 
to boost MXNet's social numbers, and I don't think waiting for a site redesign 
is ideal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to