vandanavk commented on a change in pull request #12200: [MXNET-696] 'make pylint' should run pylint under both Python 2 and Python 3 URL: https://github.com/apache/incubator-mxnet/pull/12200#discussion_r210706834
########## File path: ci/other/pylintrc ########## @@ -82,7 +82,47 @@ enable=indexing-exception,old-raise-syntax # --enable=similarities". If you want to run only the classes checker, but have # no Warning level messages displayed, use"--disable=all --enable=classes # --disable=W" -disable=design,similarities,no-self-use,attribute-defined-outside-init,locally-disabled,star-args,pointless-except,bad-option-value,global-statement,fixme,suppressed-message,useless-suppression,locally-enabled,no-member,no-name-in-module,import-error,unsubscriptable-object,unbalanced-tuple-unpacking,undefined-variable,protected-access,superfluous-parens,invalid-name,no-else-return,useless-super-delegation,len-as-condition,invalid-unary-operand-type +disable= + design, + similarities, + no-self-use, + attribute-defined-outside-init, + locally-disabled, + star-args, + pointless-except, + bad-option-value, + global-statement, + fixme, + suppressed-message, + useless-suppression, + locally-enabled, + no-member, + no-name-in-module, + import-error, + unsubscriptable-object, + unbalanced-tuple-unpacking, + undefined-variable, Review comment: undefined-variable errors were not being caught because the option is disabled by default. Moving this option to line 74 of pylintrc will ensure that it is checked in future builds. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
