haojin2 commented on a change in pull request #12200: [MXNET-696] 'make pylint'
should run pylint under both Python 2 and Python 3
URL: https://github.com/apache/incubator-mxnet/pull/12200#discussion_r210763553
##########
File path: Makefile
##########
@@ -534,7 +534,10 @@ cpplint:
--exclude_path src/operator/contrib/ctc_include
pylint:
- pylint --rcfile=$(ROOTDIR)/ci/other/pylintrc
--ignore-patterns=".*\.so$$,.*\.dll$$,.*\.dylib$$" python/mxnet
tools/caffe_converter/*.py
+ python3 --version # Python 3.5.2
Review comment:
I understand that checking on both versions is necessary and I'm supportive
of it, but I've seen some machines images that came with no python at all and
people may just randomly install only one of the python versions. To ensure an
out-of-box experience for our users we should either clearly specify
installation of both python versions as a prerequisite or we do it for them
within the script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
