szha commented on a change in pull request #11984: Generalized broadcast_like
operator
URL: https://github.com/apache/incubator-mxnet/pull/11984#discussion_r210966372
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -340,20 +351,60 @@ inline bool BroadcastLikeShape(const nnvm::NodeAttrs&
attrs,
CHECK_EQ(out_attrs->size(), 1U);
TShape& lhs_shape = (*in_attrs)[0];
TShape& rhs_shape = (*in_attrs)[1];
- TShape oshape = TShape(rhs_shape);
- if (lhs_shape.ndim() == 0 || lhs_shape.ndim() == 0) return false;
- CHECK_EQ(lhs_shape.ndim(), rhs_shape.ndim())
+ if ((lhs_shape.ndim() == 0) || (lhs_shape.ndim() == 0)) {
+ return false;
+ }
+
+ const BroadcastLikeParam& param =
nnvm::get<BroadcastLikeParam>(attrs.parsed);
+ TShape oshape;
+
+ // lhs or rhs or both params were not specified
+ if (!param.lhs_axes.has_value() || !param.rhs_axes.has_value()) {
+ CHECK_EQ(lhs_shape.ndim(), rhs_shape.ndim())
<< "Operand of shape " << lhs_shape << " cannot be broadcasted to " <<
rhs_shape;
- for (index_t i = 0; i < lhs_shape.ndim(); ++i) {
- if (rhs_shape[i] != 0) {
- CHECK(lhs_shape[i] == rhs_shape[i] || lhs_shape[i] == 1)
- << "Array cannot be broadcasted from " << lhs_shape << " to " <<
rhs_shape;
- } else {
- oshape[i] = lhs_shape[i];
+ oshape = TShape(rhs_shape);
+ for (index_t i = 0; i < lhs_shape.ndim(); ++i) {
+ if (rhs_shape[i] != 0) {
+ CHECK(lhs_shape[i] == rhs_shape[i] || lhs_shape[i] == 1)
+ << "Array cannot be broadcasted from " << lhs_shape << " to " <<
rhs_shape;
+ } else {
+ oshape[i] = lhs_shape[i];
+ }
+ }
+ } else {
+ auto lhs_axes = param.lhs_axes.value();
+ auto rhs_axes = param.rhs_axes.value();
+
+ CHECK(rhs_axes.ndim() == lhs_axes.ndim())
+ << "Input_axis and other_axis size does not match";
+
+ CHECK(lhs_axes.ndim() > 0)
+ << "Empty axes tuple is not allowed";
+
+ oshape = TShape(lhs_shape);
+ for (index_t i = 0; i < lhs_axes.ndim(); ++i) {
+ auto copyfrom = lhs_axes[i];
+ if (copyfrom < 0) {
+ copyfrom = lhs_shape.ndim() + copyfrom;
+ }
+ CHECK(copyfrom >= 0 && copyfrom < oshape.ndim())
+ << "Invalid dimension specified in lhs_axes: " << lhs_axes[i];
Review comment:
also, either print the whole lhs_axes, or print `i` to make the error
message informative.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
