rahul003 commented on a change in pull request #11234: [MXNET-535] Fix bugs in 
LR Schedulers and add warmup
URL: https://github.com/apache/incubator-mxnet/pull/11234#discussion_r211042848
 
 

 ##########
 File path: python/mxnet/lr_scheduler.py
 ##########
 @@ -29,8 +30,31 @@ class LRScheduler(object):
     base_lr : float, optional
         The initial learning rate.
     """
-    def __init__(self, base_lr=0.01):
+    def __init__(self, base_lr=0.01, warmup_steps=0, warmup_begin_lr=0, 
warmup_mode='linear'):
 
 Review comment:
   There was some for the inherited classes, but not for this base abstract 
class. Anyway, now added for all. Please check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to